Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of etags and lastmod data from sitemaps #15225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pmac
Copy link
Member

@pmac pmac commented Sep 27, 2024

These commits will need to be deployed one at a time. The 2nd one contains the migration to remove the data from the DB, while the first removes the use of the lastmod field.

@pmac pmac changed the title remove lastmod sitemap 15224 Remove use of etags and lastmod data from sitemaps Sep 27, 2024
@pmac pmac marked this pull request as draft September 27, 2024 17:56
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (bb83e23) to head (1575c72).

Files with missing lines Patch % Lines
bedrock/sitemaps/models.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15225      +/-   ##
==========================================
+ Coverage   77.88%   77.96%   +0.08%     
==========================================
  Files         163      163              
  Lines        8480     8470      -10     
==========================================
- Hits         6605     6604       -1     
+ Misses       1875     1866       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Do you plan to split into separate branches to deploy part 1 and part 2?

@pmac
Copy link
Member Author

pmac commented Oct 8, 2024

My plan was just to land this, and then push the first commit to prod, and then the 2nd.

@pmac pmac marked this pull request as ready for review October 8, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants